Implement Revit version compatibility checks by jchristel · Pull Request #3134 · pyrevitlabs/pyRevit

jchristel · 2026-02-23T22:00:31Z

Added version compatibility checks for Revit extensions based on the specified Revit year. Updated methods to include revitYear parameter for filtering extensions and components accordingly.

Name of your PR

Description

This patch updates current pyRevit loader architecture with respect to min_revit_version / max_revit_version support, and implements a design for enforcing those constraints at parse time in the C# extension parser.

Checklist

Before submitting your pull request, ensure the following requirements are met:

Code follows the PEP 8 style guide.
Code has been formatted with Black using the command:
```
pipenv run black {source_file_or_directory}
```
Changes are tested and verified to work as expected.

Related Issues

If applicable, link the issues resolved by this pull request:

Resolves [Bug]: New Loader does not respect min_revit_version / max_revit_version flags #3112

Additional Notes

Include any additional context, screenshots, or considerations for reviewers.

Thank you for contributing to pyRevit! 🎉

Added version compatibility checks for Revit extensions based on the specified Revit year. Updated methods to include revitYear parameter for filtering extensions and components accordingly.

devloai · 2026-02-23T22:00:35Z

Unable to trigger custom agent "Code Reviewer". You have run out of credits 😔
Please upgrade your plan or buy additional credits from the subscription page.

Copilot

Pull request overview

This PR implements Revit version compatibility checks for pyRevit extensions and components based on min_revit_version and max_revit_version constraints declared in bundle.yaml files. This addresses issue #3112 where pyRevit 6 was not respecting these version flags, causing extensions to load in incompatible Revit versions.

Changes:

Added IsRevitVersionCompatible helper method to validate version ranges
Updated ParseInstalledExtensions, ParseExtension, and ParseComponents methods to accept and thread through a revitYear parameter
Implemented filtering logic at both extension and component levels to skip incompatible items

dev/pyRevitLoader/pyRevitExtensionParser/ExtensionParser.cs

romangolev · 2026-02-24T00:02:38Z

Hi @jchristel, appreciate your initiative.

Check the copilot overview, it looks quite reasonable

I'd also like to mention test, that wouldn't be a fail to implement tests for this case.
Tests are located in here: dev/pyRevitLoader/pyRevitExtensionParserTester

If you don't mind adding them it's going to be lovely.

Also, there was a mechanism in the code for logging parsing errors. For instance if somebody put string or some number which does not correspond with version, app should print the exception to the output window stating the line and the reason.

Let me know what do you think and if you are down for it.

jchristel · 2026-02-24T01:11:17Z

Hi @romangolev,

No problem at all, I'm happy to update the code, add the tests and see whether I can add the logging of parsing errors. I'm new to contributing to other repos...Do I make those changes suggested and then put up a new pull request?
Ah and is there a timeframe for this?

Cheers,
Jan

romangolev · 2026-02-24T16:57:00Z

@jchristel no sweat, you can just continue committing to your branch. Just push commits, they will appear in the PR automatically.

Whenever you're ready you can request review again.

passing on logger and Revit version to ExtensionManagerService to allow for version compatibility checks and logging thereof

updated constructor to take logger and Revit version

updated IsRevitVersionCompatible to - include more detailed logging of extensions min max Revit year values parse failures and Revit 0 year occurrence. - header xml docs added

jmcouffin · 2026-02-24T20:35:55Z

No biggy, please, let's make it a draft PR until it is ready for review (and after Copilot/devloAI reviews)

jchristel · 2026-02-24T23:57:39Z

@jmcouffin @romangolev would it been better If I had moved this to a separate branch, rather than pushing it straight into develop? Apologies, I'm not familiar with working in larger projects on github. I'm happy to close this pull and re-open it on a separate branch if that helps?

jmcouffin · 2026-02-25T06:39:41Z

@jmcouffin @romangolev would it been better If I had moved this to a separate branch, rather than pushing it straight into develop? Apologies, I'm not familiar with working in larger projects on github. I'm happy to close this pull and re-open it on a separate branch if that helps?

No worries, this is okay ish.
The git flow we want to enforce is:
Branch from develop, PR against origin:develop

updated logger usage ( removed set command since not required, left logger in place in case its required down the line)

Added 5 version filtering tests as suggested by Copilot

jchristel · 2026-02-25T07:55:24Z

@romangolev

I think I'm done :)

Addressed the issues raised by Copilot
Added tests

I tried to run the tests but I couldn't get that going since Visual Studio could not find test.runsettings which is odd because I can see the file. Manual selection of the file didn't help either.

Claude recommended to add it to the .csproj file:
$(MSBuildThisFileDirectory)test.runsettings

I did not do that :) since I don't know the reason wy it is set up the way it is.

romangolev · 2026-02-26T00:58:03Z

@jchristel cool, switch from draft PR to active PR, I'll test right away

jchristel · 2026-02-26T20:31:03Z

Great, let me know if something is amiss.

…ve obsolete script file. The test now checks for 'folie_architecturale_script.dyn' instead of 'BIM1_ArrowHeadSwitcher_script.dyn', ensuring the correct file existence is asserted.

jmcouffin · 2026-03-02T12:28:52Z

works for me, added binaries and made a totally unrelated test fix (dyn). bad boy!
@jchristel thanks for the contribution

github-actions · 2026-03-02T12:42:49Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1233-wip

github-actions · 2026-03-02T12:56:53Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1244-wip

github-actions · 2026-03-02T14:08:08Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1357-wip

github-actions · 2026-03-02T14:14:05Z

📦 New work-in-progress (wip) builds are available for 6.1.0.26061+1403-wip

Implement Revit version compatibility checks

22f3ed8

Added version compatibility checks for Revit extensions based on the specified Revit year. Updated methods to include revitYear parameter for filtering extensions and components accordingly.

Copilot AI review requested due to automatic review settings February 23, 2026 22:00

Copilot started reviewing on behalf of jchristel February 23, 2026 22:01 View session

jchristel mentioned this pull request Feb 23, 2026

[Bug]: New Loader does not respect min_revit_version / max_revit_version flags #3112

Closed

5 tasks

Copilot AI reviewed Feb 23, 2026

View reviewed changes

jchristel added 3 commits February 25, 2026 07:08

Update ServiceFactory.cs

aa49f40

passing on logger and Revit version to ExtensionManagerService to allow for version compatibility checks and logging thereof

Update ExtensionManagerService.cs

73e849a

updated constructor to take logger and Revit version

Update ExtensionParser.cs

6a2b63b

updated IsRevitVersionCompatible to - include more detailed logging of extensions min max Revit year values parse failures and Revit 0 year occurrence. - header xml docs added

jmcouffin marked this pull request as draft February 24, 2026 20:36

jmcouffin assigned jchristel and romangolev and unassigned romangolev Feb 24, 2026

jmcouffin requested a review from romangolev February 24, 2026 21:24

jmcouffin added the Backward Compatibility Backward Compatibility Issue with Older Revit Versions label Feb 24, 2026

jchristel added 2 commits February 25, 2026 18:50

Update ExtensionManagerService.cs

ecf34e2

updated logger usage ( removed set command since not required, left logger in place in case its required down the line)

Added VersionFilteringTests

d86cf1e

Added 5 version filtering tests as suggested by Copilot

jmcouffin marked this pull request as ready for review February 26, 2026 06:31

jmcouffin added 2 commits March 2, 2026 12:36

Merge branch 'develop' into develop

5392899

Update DynamoScriptTests to reflect changes in script naming and remo…

facde6f

…ve obsolete script file. The test now checks for 'folie_architecturale_script.dyn' instead of 'BIM1_ArrowHeadSwitcher_script.dyn', ensuring the correct file existence is asserted.

jmcouffin added the Installer Issues related to the pyRevit installer [subsystem] label Mar 2, 2026

chore: update binaries

6279a7b

jmcouffin merged commit e99b812 into pyrevitlabs:develop Mar 2, 2026

Uh oh!

Conversation

jchristel commented Feb 23, 2026

Name of your PR

Description

Checklist

Related Issues

Additional Notes

Uh oh!

devloai bot commented Feb 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

romangolev commented Feb 24, 2026

Uh oh!

jchristel commented Feb 24, 2026

Uh oh!

romangolev commented Feb 24, 2026

Uh oh!

jmcouffin commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jchristel commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmcouffin commented Feb 25, 2026

Uh oh!

jchristel commented Feb 25, 2026

Uh oh!

romangolev commented Feb 26, 2026

Uh oh!

jchristel commented Feb 26, 2026

Uh oh!

jmcouffin commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jmcouffin commented Feb 24, 2026 •

edited

Loading

jchristel commented Feb 24, 2026 •

edited

Loading