Fix EnsembleSampler second split to use complementary inactive chains#2189
Open
amifalk wants to merge 1 commit into
Open
Fix EnsembleSampler second split to use complementary inactive chains#2189amifalk wants to merge 1 commit into
amifalk wants to merge 1 commit into
Conversation
Contributor
Author
|
The original PR (#2135) seems dead but was good to go save for failing lint. |
Contributor
Author
|
@Qazalbash looks like this is failing because of the new toml formatting checks? |
Collaborator
The second sub-iteration in EnsembleSampler.sample incorrectly updated the second half of chains against itself instead of the first half. Add a deterministic regression test that fails under the previous split logic and verifies complementary-half updates.
amifalk
force-pushed
the
ensemble-sampler-bf
branch
from
5a81279 to
30e087e
Compare
Collaborator
|
This looks identical to #2135. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second sub-iteration in EnsembleSampler.sample incorrectly updated the second half of chains against itself instead of the first half. Add a deterministic regression test that fails under the previous split logic and verifies complementary-half updates.
Original Author: @jackkohm