Skip to content

Conversation

@theoparis
Copy link
Contributor

  • Ran treefmt which created some minor formatting changes
  • Added a nix overlay and nix package to the flake.nix
  • Added treefmt to the devShell
  • I believe vendorHash needs to be changed every time the dependencies change.

// Sets the value at a specific pathway, but checks if we were looking for a specific
// value or not before doing it.
func (cfr *ConfigurationFileReplacement) SetAtPathway(c *gabs.Container, path string, value string) error {
func (cfr *ConfigurationFileReplacement) SetAtPathway(c *gabs.Container, path, value string) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were so many types changed away from strings?

Copy link
Contributor Author

@theoparis theoparis Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the changes that were appplied by the formatter that was previously used. I can see if using regular gofmt would fix it.

@ChecksumDev
Copy link
Member

I am so sorry 💀

@theoparis theoparis force-pushed the push-xzmpmmrtqmwr branch 3 times, most recently from 018ebd5 to ad78d39 Compare September 22, 2025 23:07
@theoparis theoparis closed this Oct 12, 2025
@theoparis theoparis reopened this Oct 31, 2025
@theoparis
Copy link
Contributor Author

theoparis commented Oct 31, 2025

Well it turns out someone forgot to run go fmt so now there's two options...

  1. Pyro could introduce all of the new formatting changes from this PR
  2. I can disable gofmt entirely and revert the new formatting changes... but that doesn't sound like an ideal solution

@naterfute naterfute merged commit 2d5fec0 into pyrohost:main Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants