Skip to content

Conversation

@yeenbean
Copy link

@yeenbean yeenbean commented Sep 27, 2025

Closes #13

@yeenbean yeenbean mentioned this pull request Sep 27, 2025
@fangmarks
Copy link
Member

@ChecksumDev @naterfute :3

@naterfute
Copy link
Contributor

This would require building rustic every time, which is.... very inefficient. They offer pre-built binaries which I would like to opt for. I'm currently working on them.

@naterfute
Copy link
Contributor

I added code to auto install it from the pre-built binaries from rustic themselves f131de3

@naterfute naterfute closed this Sep 30, 2025
@yeenbean
Copy link
Author

yeenbean commented Sep 30, 2025

@naterfute binstall pulls binaries by default and falls back to building if they don't exist. I suppose I should have explained that in my PR...

@naterfute
Copy link
Contributor

I... Did not know that.

@yeenbean
Copy link
Author

All good, I'll take the fault for that for not communicating it. :P Your solution works just as well. They have binaries for the couple platforms that we'd need to support.

@naterfute
Copy link
Contributor

Which one do you think will be better, the url or the binstall? You obviously have more experience with this than I do? they will be basically the same yeah? your is just cleaner. So we can just merge that one in.

@yeenbean
Copy link
Author

yeenbean commented Sep 30, 2025

Let's either hold off on merging or merge yours in for now.

After I submitted the PR, I noticed mine does not grab arm builds with binstall, and I'd like to see if I can get that sorted so image builds don't take forever.

If you merge yours, I'll rebase and work from that version of the Dockerfile.

@naterfute
Copy link
Contributor

Cool, alright. Mine is already on the main branch, so just go at it and reopen this if you figure out it(or open a new one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docker container exits prematurely due to rustic missing

3 participants