Skip to content

refacto: fix template inventories and simplify hosts (PR Refacto #2) #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
m-julio wants to merge 1 commit into
base: fix/clean-group-vars
Choose a base branch
from
Open

refacto: fix template inventories and simplify hosts (PR Refacto #2) #8

m-julio wants to merge 1 commit into from

Conversation

@m-julio
Copy link
Collaborator

@m-julio m-julio commented Dec 14, 2025 •
edited
Loading

  • Fill inventory template with missing hosts : "annotation_server" and "mediamtx_server"
  • Delete hosts with suffix "-test" and "-prod" since it should be dealt with different inventories rather then different hosts
  • Use always the same naming for mediamtx (not "mediamtx_server" and "mediamtx" depending on the playbook)
  • Change name of inventory used in make file

@m-julio m-julio force-pushed the fix/clean-inventories branch from 323f8f0 to faf2ef2 Compare December 14, 2025 10:26
@m-julio m-julio force-pushed the fix/clean-group-vars branch from ca9b6eb to 3d39f66 Compare December 17, 2025 07:23
@m-julio m-julio force-pushed the fix/clean-inventories branch from faf2ef2 to 2982d7b Compare December 17, 2025 07:28
@MateoLostanlen MateoLostanlen self-requested a review December 19, 2025 07:20
MateoLostanlen
MateoLostanlen approved these changes Dec 19, 2025
View reviewed changes
Copy link
Member

@MateoLostanlen MateoLostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @m-julio , thanks for the PR, it looks good to me. Have you tested it by merging all the PRs on both repositories? Worst case, we can merge and then make a fix PR afterward, that might be simpler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MateoLostanlen MateoLostanlen MateoLostanlen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@m-julio @MateoLostanlen