-
-
Notifications
You must be signed in to change notification settings - Fork 10
Split detections #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
MateoLostanlen
wants to merge
75
commits into
main
Choose a base branch
from
split_detections
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Split detections #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/app/api/api_v1/router.py # src/app/api/dependencies.py
0cd9889 to
8c2aa06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #538 and further refines the detection and sequencing logic by making pose handling explicit and by tightening payload validation and sequence attribution.
What’s new in this PR
Detection model and API changes
Dropped
Detection.azimuthMade
pose_idmandatory for all detectionsCreation logic now:
others_bboxesSequencing logic improvements
Sequences are now looked up using:
camera_idpose_idlast_seenFor each new detection:
Its bbox is parsed
A candidate sequence is reused only if the last bbox overlaps
Otherwise, a new sequence is created
This prevents merging detections that are spatially distant but temporally close
Helpers refactor
Why this matters
The main goal of this change is to separate unrelated detections coming from the same image.
When a single frame contains both a real fire and a false positive, these detections have nothing in common spatially or semantically and must not end up in the same sequence.
By enforcing one detection per bbox and reusing sequences only when spatial overlap exists, we ensure that fires and false positives evolve independently, even if they originate from the same image and timestamp