Ensure burn rate factors are accurate, and add exhaustion
label
#775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following,
Windows()
function from14, 7, 2, 1
to14, 5.6, 2.8, 1
to more accurately represent 28 day burn rate in the following cases (as per conversation offline with @metalmatze),Windows
which describe its functionality for posterity.exhaustion
label to all budget burn alerts, which represents time till the error budget is fully exhausted.Test_windows
to account for various common SLO windows like90d, 84d, 30d, 28d, 14d & 7d
Most of this large diff is to account for changes in tests. Let me know what you think! 🙂