chore: fix missleading errors total grafana #969
Conversation
examples/grafana/detail.json
Outdated
| @@ -529,7 +529,7 @@ | |||
| "uid": "${DS_PROMETHEUS}" | |||
| }, | |||
| "editorMode": "code", | |||
| "expr": "sum(rate(pyrra_requests_total{slo=\"$slo\"}[$__rate_interval]))", | |||
| "expr": "sum(rate(pyrra_requests:rate5m{slo=\"$slo\"}[$__rate_interval]))", | |||
There was a problem hiding this comment.
This doesn't make that much sense anymore. Given we already have the :rate5m we don't need to do anything except pyrra_requests:rate5m{slo=\"$slo\"}.
I guess we'll lose the flexibility to use rate[$__rate_interval] but being correct is more important.
There was a problem hiding this comment.
We could have multiple rate interval pre-computed i.e. rate5m, rate1h, rate1d, how about that?
| @@ -598,7 +598,7 @@ | |||
| } | |||
| ] | |||
| }, | |||
| "unit": "percentunit" | |||
There was a problem hiding this comment.
To keep the RED (Requests, Error Rate, Duration) type of panels, how about actually using the error rate percentage?
|
I'm looking at this again. Given that we do similar things for the other queries, I wonder if we can construct a query (using the I prefer to keep only distinct labels; however, keeping all labels and then later summing them away doesn't seem too bad. |
Simplest, but not necessarily the best way to fix #968 968