fix warnings in the doctests for dynamic_lisa_rose

[weikang9009]

• not importing splot
• addressing UserWarning: No data for colormapping provided via 'c'. #244

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.2%. Comparing base (3fa6225) to head (2885d8f).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##            main    #246     +/-   ##
=======================================
- Coverage   88.2%   88.2%   -0.1%     
=======================================
  Files         10      10             
  Lines       1591    1584      -7     
=======================================
- Hits        1404    1397      -7     
  Misses       187     187             

Files with missing lines	Coverage Δ
giddy/plotting.py	92.4% <100.0%> (-0.3%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jGaboardi]

@weikang9009 awesome!

Should we also tie in these other splot removals in this PR?

• environment.yml
• pyproject.toml
• and the ci/*.yml files

[weikang9009]

Yes! I thought those were removed - sorry for misreading and closing that issue.

I've just pushed another commit to this PR to remove splot from those files.

[weikang9009]

One of the CI testing failed because of https://github.com/pysal/giddy/blob/main/giddy/plotting.py#L591 I think esda has this plotting functionality? Since esda is a dependency, we can replace it with the esda function.

[jGaboardi]

One of the CI testing failed because of https://github.com/pysal/giddy/blob/main/giddy/plotting.py#L591 I think esda has this plotting functionality? Since esda is a dependency, we can replace it with the esda function.

esda>=2.7 has the functionality, so if simply bump the minimum esda version to 2.7 we can clean up that logic block nicely.

Thoughts?

[weikang9009]

Sounds good to me! Wei Kang Assistant Professor, Center for Geospatial Sciences School of Public Policy, University of California Riverside Website // weikang9009.github.io

…

On Wed, Dec 3, 2025 at 1:32 PM James Gaboardi ***@***.***> wrote: *jGaboardi* left a comment (pysal/giddy#246) <#246 (comment)> One of the CI testing failed <https://github.com/pysal/giddy/actions/runs/19907261620/job/57066677075?pr=246> because of https://github.com/pysal/giddy/blob/main/giddy/plotting.py#L591 I think esda has this plotting functionality? Since esda is a dependency, we can replace it with the esda function. esda>=2.7 has the functionality, so if simply bump the minimum esda version to 2.7 we can clean up that logic block nicely. Thoughts? — Reply to this email directly, view it on GitHub <#246 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYEWNBS4CQOWN67LJJLO2L375JHRAVCNFSM6AAAAACN6MPZNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMBYHEZDIMBQHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[jGaboardi]

I'll see about making those changes in your branch here and push back up.

[jGaboardi]

@weikang9009 – we needed to bump the minimum libpysal, as well -- but now we have fully green CI 🎉

I'm approving, but I'll wait for you to look over my changes and merge (since I can't tag you as reviewer on your own PR).