Skip to content

Fix: properly render P-Median model formulation in docs (#466) #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

Abhishek-Dimri
Copy link
Contributor

@Abhishek-Dimri Abhishek-Dimri commented Apr 20, 2025

This PR fixes the incorrect rendering of the P-Median mathematical formulation in the documentation site.

  • Reformatted the equations using display math blocks for compatibility with Sphinx/Markdown.
  • Ensures better readability and consistency across platforms (Jupyter, ReadTheDocs, etc.).

Before-
image
and
image

After-
image
and
image

Note:
Some small phrasing changes were made for clarity and readability in the documentation (e.g., "Index referencing demand nodes" vs. "Index referencing nodes of the network as demand"). If you prefer the original phrasing, let me know, and I'm happy to revert it.

Fixes #466

Copy link

codecov bot commented Apr 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.8%. Comparing base (13ca45e) to head (1a2cbe5).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #483   +/-   ##
=====================================
  Coverage   77.8%   77.8%           
=====================================
  Files         27      27           
  Lines       2638    2638           
=====================================
  Hits        2053    2053           
  Misses       585     585           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Much appreciated!

@martinfleis martinfleis requested a review from jGaboardi April 25, 2025 10:46
@jGaboardi
Copy link
Member

Thanks!

@jGaboardi jGaboardi added the docs label Apr 25, 2025
@jGaboardi jGaboardi merged commit 10f5997 into pysal:main Apr 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

formulations on docs site not rendering properly
3 participants