TST: geopandas compat #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jGaboardi
approved these changes
Dec 8, 2025
knaaptime
approved these changes
Dec 8, 2025
Member
knaaptime
left a comment
knaaptime
left a comment
There was a problem hiding this comment.
got it. So in newer geopandas it's invalid to set the crs "directly" via the attribute, but instead needs to be done via the setter?
Member
Author
|
Yes. Setting it directly is considered unsafe as it easily allows you to assign wrong CRS without transforming the coords. Leads to issues typically with beginners or non-spatial folks code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the CRS removal to be future-proof.