fix openmp linking on macos#144
Closed
karosc wants to merge 1 commit into
Closed
Conversation
Collaborator
|
@karosc Nice catch! After implementing this several years ago and giving it some thought in the intervening time, I've come to the conclusion that the wheel build is the wrong place to handle swmm's OpenMP dependency on MacOS. It more naturally fits as part of the swmm library build. Besides being in the wrong place it also doesn't work ... which you cleverly figured out! I am working on a PR to move this into the swmm-solver. I will incorporate the include path and compiler flag changes you have identified. I appreciate your help on this! Thank you! |
Member
Author
|
@michaeltryby, I agree. SWMM feels like a more natural place for this cmake fu. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression that prevents openmp from linking on macos
Adding
set(OpenMP_AVAILABLE TRUE)gets swmm-solver to attempt linking to omp project built on macosAdding the target_include_directories block below gets swmm-solver to find omp.h when compiling.