Conversation
RonnyPfannschmidt
commented
Aug 17, 2024
RonnyPfannschmidt
commented
- migrate to pyproject.toml tooling
- migrate to https://github.com/hynek/build-and-inspect-python-package/
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
LGTM!
Left a few suggestions.
pyproject.toml
Outdated
| [project] | ||
| name = "pluggy" | ||
| license = {text = "MIT"} | ||
| authors = [{name = "Holger Krekel", email = "holger@merlinux.eu"}] |
There was a problem hiding this comment.
While at it should we update this? Not sure to what exactly though...
There was a problem hiding this comment.
I'm up for being on the hook
There was a problem hiding this comment.
I'm up for being on the hook
There was a problem hiding this comment.
I was thinking more if it is appropriate to add pytest core team <core@pytest.org> or something like that.
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
The pyproject.toml migration LGTM, I'm not qualified to review the rest. Maybe adding pyproject.fmt first in pre-commit would be great.
RonnyPfannschmidt
force-pushed
the
baipp
branch
from
4816b4b to
0723def
Compare
|
@RonnyPfannschmidt gentle ping here. |
|
Probably worth updating the title/description of the PR before merging. |
RonnyPfannschmidt
force-pushed
the
baipp
branch
2 times, most recently
from
af435fe to
4152891
Compare
RonnyPfannschmidt
changed the title
RonnyPfannschmidt
changed the title
RonnyPfannschmidt
force-pushed
the
baipp
branch
from
05e57ff to
42fc7f2
Compare
|
I guess this is ready to merge? |
3 participants
