Fix the pinned build-system version - #1212
Merged
Merged
Conversation
Member
|
Thanks, this looks sensible, as far as I can see! I'm traveling right now, will have a closer look / merge next week when I have access to a computer. |
setuptools v45.x doesn't support `pyproject.toml` files. v62.1.x and higher do, and continue to support Python 3.7. Reproducer: ``` # Create a venv python -m venv venv-demo source venv-demo/bin/activate # Install setuptools and build python -m pip install setuptools==45.0.0 build # Build the package using the already-installed setuptools python -m build --no-isolation ``` This results in the following error: ``` ERROR Backend 'setuptools.build_meta' is not available. ``` Changing the reproducer to use setuptools 61.2.0 demonstrates that the issue is resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes
setuptools v45.x doesn't support
pyproject.tomlfiles.v62.1.x and higher do, and continue to support Python 3.7.
Reproducer:
This results in the following error:
Changing the reproducer to use setuptools 61.2.0 demonstrates that the issue is resolved.
Tasks