-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call loop.shutdown_asyncgens
before closing the event loop
#1034
Conversation
f591f07
to
761f742
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1034 +/- ##
==========================================
+ Coverage 91.10% 91.13% +0.03%
==========================================
Files 2 2
Lines 562 564 +2
Branches 74 74
==========================================
+ Hits 512 514 +2
Misses 30 30
Partials 20 20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid patch, thank you!
Can you please add an entry to docs/reference/changelog.rst as well, where you briefly explain the change and link to this PR? We can create another patch release for this. Just set the date to UNRELEASED and we'll handle the rest.
@seifertm Added a comment! |
Thanks for the contribution! |
Add a comment
f2e620b
to
6ba99b7
Compare
Squashed the commits and extended commit message. |
#222 was closed, mentioning the issues being resolved in the yet-to-be-done #235, running with
-W error
in Python 3.13, currently fails when there are unclosed async generators.This is a minimally invasive fix, without attempting to behave like
asyncio.run
on shutdown in all other scenarios.