feat(pytest_asyncio): raise error instead of deprecation warning on async fixtures#1348
Open
dzhalaevd wants to merge 4 commits intopytest-dev:mainfrom
Open
feat(pytest_asyncio): raise error instead of deprecation warning on async fixtures#1348dzhalaevd wants to merge 4 commits intopytest-dev:mainfrom
dzhalaevd wants to merge 4 commits intopytest-dev:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1348 +/- ##
=======================================
Coverage 93.64% 93.64%
=======================================
Files 2 2
Lines 409 409
Branches 44 44
=======================================
Hits 383 383
Misses 20 20
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
using
@pytest.fixtureon async fixtures emitted only a deprecation warning, but plan was to make it an exceptionCloses: #1202
Related issue: #1202
How it was fixed?
pytest.UsageErrorinstead ofPytestDeprecationWarningwhen using@pytest.fixtureon async fixtures in strict mode (I'm not really sure aboutpytest.UsageErrorbecause some different func uses usualValueError)