-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README to provide more clear examples #105
Conversation
Hi @alissa-huskey, thanks for sending a contribution! I'm sorry to keep you waiting; I haven't been active on GitHub for a little while (because real life got busy) and I didn't see the notification about your PR. If you don't mind waiting a bit longer, I'd like to come back to this and review it over the weekend when I can give it my full attention. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again! These changes mostly look good, I just made a few suggestions.
Sorry again for the delayed response; I'll try to keep checking back so I don't miss further activity here.
No worries about the delay! Real life happens. I tend to be on github in fits and starts anyway, so I never expect a prompt response, if any. I believe I addressed all of your feedback. Additionally I changed the monkeypatch link to point to the stable pytest.org docs URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call on that monkeypatch change.
Thanks again; I appreciate both the contribution and your patience!
I think the CI failures are because of #110, so I'll merge that and then get this finalized. |
This brings in the fix to CI for Python 3.7.
I updated the
README
with some of my own code examples and did a little cleanup/polish.WSGI
example, as I wasn't able to get the previous example working.code
directives instead of literal blocks to syntax highlight python code.