Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle dependency markers with the same name #105

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

mrbean-bremen
Copy link
Member

This came up with tests derived from a base class with dependency markers, so that all derived tests used the same alias name.

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (19dae40) 97.21% compared to head (13651bb) 96.82%.
Report is 5 commits behind head on main.

Files Patch % Lines
pytest_order/sorter.py 88.46% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   97.21%   96.82%   -0.40%     
==========================================
  Files           5        5              
  Lines         575      598      +23     
  Branches      136      142       +6     
==========================================
+ Hits          559      579      +20     
- Misses          9       10       +1     
- Partials        7        9       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- the same name may be used in different modules
@mrbean-bremen mrbean-bremen merged commit b5bb06b into pytest-dev:main Feb 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ordering breaking with pytest-xdist + pytest-dependency
2 participants