tmpdir: fix insecure temporary directory vulnerability (CVE-2025-71176)#14343
Open
bluetech wants to merge 1 commit intopytest-dev:mainfrom
Open
tmpdir: fix insecure temporary directory vulnerability (CVE-2025-71176)#14343bluetech wants to merge 1 commit intopytest-dev:mainfrom
bluetech wants to merge 1 commit intopytest-dev:mainfrom
Conversation
A previous fix for insecure temporary directory issue c49100c wasn't sufficient because it followed symlinks. Stop following symlinks, and reject if a symlink; we know it shouldn't be. Fix pytest-dev#14279. [0] https://www.openwall.com/lists/oss-security/2026/01/21/5
7479218 to
7161cfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my proposed alternative to #13669 as discussed in the issue. I think we should go with the simple fix for now. I think this one should be safe to backport.
A previous fix for insecure temporary directory issue c49100c wasn't sufficient because it followed symlinks.
Stop following symlinks, and reject if a symlink; we know it shouldn't be.
Fix #14279.
[0] https://www.openwall.com/lists/oss-security/2026/01/21/5