Fix: warning filters set in pytest_configure being ignored#14346
Open
harsh21234i wants to merge 1 commit intopytest-dev:mainfrom
Open
Fix: warning filters set in pytest_configure being ignored#14346harsh21234i wants to merge 1 commit intopytest-dev:mainfrom
harsh21234i wants to merge 1 commit intopytest-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where warnings configured using warnings.filterwarnings()
inside pytest_configure are ignored.
During the config stage, warnings.catch_warnings() resets the global
warnings filter state, causing user-defined filters to be lost when
pytest applies its own filters.
This change preserves existing filters before applying pytest-configured
filters and restores them afterward, ensuring that user-defined warning
filters behave as expected.
The fix is scoped to issue_config_time_warning to avoid affecting
runtime warning handling and maintains correct precedence between
command-line, ini, and mark-based filters.
All tests pass locally. #13284