Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cope with field_transformer being a generator #1417

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

ashb
Copy link
Contributor

@ashb ashb commented Mar 12, 2025

This worked on 25.1.0 but was inadvertently broken by #1401

Fixes #1416

Pull Request Check List

  • Do not open pull requests from your main branch – use a separate branch!
    • There's a ton of footguns waiting if you don't heed this warning. You can still go back to your project, create a branch from your main branch, push it, and open the pull request from the new branch.
    • This is not a pre-requisite for your pull request to be accepted, but you have been warned.
  • Added tests for changed code.
    Our CI fails if coverage is not 100%.
  • New features have been added to our Hypothesis testing strategy.
  • Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).
    • ...and used in the stub test file tests/typing_example.py.
    • If they've been added to attr/__init__.pyi, they've also been re-imported in attrs/__init__.pyi.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changes to the signatures of @attr.s() and @attrs.define() have to be added by hand too.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
      The next version is the second number in the current release + 1.
      The first number represents the current year.
      So if the current version on PyPI is 22.2.0, the next version is gonna be 22.3.0.
      If the next version is the first in the new year, it'll be 23.1.0.
      • If something changed that affects both attrs.define() and attr.s(), you have to add version directives to both.
  • Documentation in .rst and .md files is written using semantic newlines.
  • Changes (and possible deprecations) have news fragments in changelog.d.
  • Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.

@ashb
Copy link
Contributor Author

ashb commented Mar 12, 2025

I think this should have coverage, but pre-commit was complaining about that locally, but I couldn't quite work out what it was saying wasn't covered.

Oh doc, not code coverage. Fixed

This worked on 25.1.0 but was inadvertently broken by python-attrs#1401
@ashb ashb force-pushed the field_transformer-generator branch from 805ab29 to f0beb60 Compare March 12, 2025 16:53
Co-authored-by: Ash Berlin-Taylor <[email protected]>
Copy link
Member

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hynek hynek added this pull request to the merge queue Mar 13, 2025
Merged via the queue into python-attrs:main with commit 3b0378d Mar 13, 2025
19 checks passed
hynek added a commit that referenced this pull request Mar 13, 2025
@ashb ashb deleted the field_transformer-generator branch March 13, 2025 10:29
luketainton pushed a commit to luketainton/pypilot that referenced this pull request Mar 13, 2025
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [attrs](https://github.com/python-attrs/attrs) ([changelog](https://www.attrs.org/en/stable/changelog.html)) | project.dependencies | minor | `==25.2.0` -> `==25.3.0` |

---

### Release Notes

<details>
<summary>python-attrs/attrs (attrs)</summary>

### [`v25.3.0`](https://github.com/python-attrs/attrs/blob/HEAD/CHANGELOG.md#2530---2025-03-13)

[Compare Source](python-attrs/attrs@25.2.0...25.3.0)

##### Changes

-   Restore support for generator-based `field_transformer`s.
    [#&#8203;1417](python-attrs/attrs#1417)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xOTkuMSIsInVwZGF0ZWRJblZlciI6IjM5LjE5OS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->

Reviewed-on: https://git.tainton.uk/repos/pypilot/pulls/317
Reviewed-by: Luke Tainton <[email protected]>
Co-authored-by: Renovate [BOT] <[email protected]>
Co-committed-by: Renovate [BOT] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a Subclassed instance now errors with got an unexpected keyword argument
4 participants