-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More breaking changes for 11.0 #208
Conversation
✅ Deploy Preview for bot-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
docs/changelog.rst
Outdated
@@ -4,7 +4,12 @@ | |||
Changelog | |||
========= | |||
|
|||
- :breaking:`208` Split ``fakeredis`` optional dependency from the ``async-rediscache`` extra. You can now install with ``[fakeredis]`` to just install fakeredis (with lua support), ``[async-rediscache]`` to install just ``async-rediscache``, or use either ``[all]`` or ``[async-rediscache,fakeredis]`` to install both. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think people tend to jump on breaking
changes more than other ones, which makes me wonder whether it's a good idea to mention that we're splitting them in order to allow for python 3.12 support here.
35b0f1b
to
9a49719
Compare
This adds a few more breaking changes that I've wanted to do for a while since we're making a new major version.
Changelog preview
v11 Github release notes draft
Breaking Changes
This release has a number of breaking changes.
fakeredis
is no longer installed along side theasync-rediscache
extra. If you needfakeredis
you can use the[fakeredis]
extra. You can also use either[all]
or[async-rediscache,fakeredis]
to install both.sync_app_commands
inpydis_core.BotBase.load_extensions()
should_raise
inpydis_core.site_api.APIClient.maybe_raise_for_status()
fail_silently
inpydis_core.utils.checks.in_whitelist_check()
pagination_emojis, lines, ctx, embed
inpydis_core.utils.pagination.LinePaginator.paginate()
What's Changed
fakeredis
optional dependency from theasync-rediscache
extra, by @ChrisLovering in More breaking changes for 11.0 #208pydis_core.BotBase
, by @shtlrs in Document the instance attributes of BotBase #204Full Changelog: v10.7.0...v11.0.0