Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More breaking changes for 11.0 #208

Merged
merged 5 commits into from
Mar 18, 2024
Merged

More breaking changes for 11.0 #208

merged 5 commits into from
Mar 18, 2024

Conversation

ChrisLovering
Copy link
Member

@ChrisLovering ChrisLovering commented Mar 4, 2024

This adds a few more breaking changes that I've wanted to do for a while since we're making a new major version.

  1. Drop Pydantic 1.X support. We had to use a deprecated function for backwards compat. It's been out long enough that I feel comfortable dropping support for it.
  2. Spliting fakeredis from the async-rediscache extra. This means that uses of this lib can install async-redis cache without having to install fakeredis, this allows for 3.12 support
  3. Drop support for 3.10. Supporting the last 2 minor versions seems reaosnable. Dropping 3.10 means we can drop a few imports that were annoying to keep up to date.

Changelog preview

image

v11 Github release notes draft

Breaking Changes

This release has a number of breaking changes.

  1. Pydantic 1.x is no longer supported. You can follow the Pydantic migration guide if you havne't updated yet.
  2. fakeredis is no longer installed along side the async-rediscache extra. If you need fakeredis you can use the [fakeredis] extra. You can also use either [all] or [async-rediscache,fakeredis] to install both.
  3. Python 3.10 is no longer supported.
  4. Boolean default and boolean-typed positional arguments in function definition are now keyword args only. The arg names and functions are listed below.
    • sync_app_commands in pydis_core.BotBase.load_extensions()
    • should_raise in pydis_core.site_api.APIClient.maybe_raise_for_status()
    • fail_silently in pydis_core.utils.checks.in_whitelist_check()
    • All args other than pagination_emojis, lines, ctx, embed in pydis_core.utils.pagination.LinePaginator.paginate()

What's Changed

Full Changelog: v10.7.0...v11.0.0

Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for bot-core ready!

Name Link
🔨 Latest commit 9a49719
🔍 Latest deploy log https://app.netlify.com/sites/bot-core/deploys/65f818b942d8900008bc2b5f
😎 Deploy Preview https://deploy-preview-208--bot-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ChrisLovering ChrisLovering changed the title Breakiing changes for 11.0 More breaking changes for 11.0 Mar 4, 2024
@@ -4,7 +4,12 @@
Changelog
=========

- :breaking:`208` Split ``fakeredis`` optional dependency from the ``async-rediscache`` extra. You can now install with ``[fakeredis]`` to just install fakeredis (with lua support), ``[async-rediscache]`` to install just ``async-rediscache``, or use either ``[all]`` or ``[async-rediscache,fakeredis]`` to install both.
Copy link
Member

@shtlrs shtlrs Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think people tend to jump on breaking changes more than other ones, which makes me wonder whether it's a good idea to mention that we're splitting them in order to allow for python 3.12 support here.

@ChrisLovering ChrisLovering force-pushed the breaking-deps-changes branch from 35b0f1b to 9a49719 Compare March 18, 2024 10:34
@ChrisLovering ChrisLovering merged commit 9a49719 into main Mar 18, 2024
7 of 8 checks passed
@ChrisLovering ChrisLovering deleted the breaking-deps-changes branch March 18, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants