Add support for running fakeredis on 3.12 #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lupa now has support for 3.12, so this restriction can be removed
✅ Deploy Preview for bot-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4 tasks
mbaruh
reviewed
Mar 24, 2024
| if user.id in allowed_users or any(role.id in allowed_roles for role in getattr(user, "roles", [])): | ||
| return True | ||
| return False | ||
| return bool( |
There was a problem hiding this comment.
It's just what ruff auto-corrected it to. Just a bracket would probably work too, but I found this more readable.
There was a problem hiding this comment.
When running poetry run task docs on Python 3.12 without this change, it errors saying that it couldn't import docs.
I noticed we were adding the project root to the path further down anyway so just moved it up.
wookie184
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got a PR up on lance ready to test this as needed.