Use python version specifier that dependabot can understand #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bot-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wookie184
commented
May 14, 2024
Comment on lines
-487
to
-489
| [package.dependencies] | ||
| tomli = {version = "*", optional = true, markers = "python_full_version <= \"3.11.0a6\" and extra == \"toml\""} | ||
|
|
There was a problem hiding this comment.
Interesting, I think that 3.11.* includes alpha/beta releases, but ^3.11 doesn't. I think not including them is correct.
ChrisLovering
approved these changes
May 14, 2024
|
I don't think we need to cut a release for this, since it's specifcally to fix a dependabot issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot was failing with logs saying
Illformed requirement ["~>3.11.0 || 3"]Confirmed on a fork that this was the issue, changing the python version specifier made dependabot alerts work properly.