Build status #33
Merged
Build status #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
reviewed
Jan 12, 2025
build_status.py
Outdated
Comment on lines
22
to
25
| defaults = config['defaults'] | ||
| for code, language in languages.items(): | ||
| language_code = code.lower().replace('_', '-') | ||
| in_switcher = language.get('in_prod', defaults['in_prod']) |
There was a problem hiding this comment.
Suggested change
| defaults = config['defaults'] | |
| for code, language in languages.items(): | |
| language_code = code.lower().replace('_', '-') | |
| in_switcher = language.get('in_prod', defaults['in_prod']) | |
| for code, language in languages.items(): | |
| language_code = code.lower().replace('_', '-') | |
| in_switcher = language.get('in_prod', True) |
There was a problem hiding this comment.
Thank you for reviewing! I agree that this suggestion improves readability. I'm concerned it doesn't honour https://github.com/python/docsbuild-scripts/blob/e4a8aff9772738a63d0945042777d18c3d926930/config.toml#L3; I was thinking if to propose a simplification upstream, but it makes the toml config file better self-describing
There was a problem hiding this comment.
I've simplified this code a bit https://github.com/m-aciek/pydocs-translation-dashboard/pull/33/commits/2db4095e9ff47d33a578234b5aa9f0f52fd6f940
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
AA-Turner
approved these changes
Jan 12, 2025
hugovk
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31.