Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry Plausible on BadZipFile #51

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions visitors.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import csv
import io
import urllib
import logging
import urllib.parse
import zipfile

from requests import Session
Expand All @@ -10,12 +11,21 @@ def get_number_of_visitors(language: str, requests: Session) -> int:
params = urllib.parse.urlencode(
{'filters': f'[["contains","event:page",["/{language}/"]]]', 'period': 'all'}
)
r = requests.get(
f'https://plausible.io/docs.python.org/export?{params}', timeout=20
)
with (
zipfile.ZipFile(io.BytesIO(r.content), 'r') as z,
z.open('visitors.csv') as csv_file,
):
csv_reader = csv.DictReader(io.TextIOWrapper(csv_file))
return sum(int(row['visitors']) for row in csv_reader)
for _ in range(2):
r = requests.get(
f'https://plausible.io/docs.python.org/export?{params}', timeout=40
)
try:
with (
zipfile.ZipFile(io.BytesIO(r.content), 'r') as z,
z.open('visitors.csv') as csv_file,
):
csv_reader = csv.DictReader(io.TextIOWrapper(csv_file))
return sum(int(row['visitors']) for row in csv_reader)
except zipfile.BadZipFile as bad_zip_file:
logging.exception(
f'Plausible responded with broken archive for {language}. Retrying.'
)
exception = bad_zip_file
continue
raise exception
Loading