Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use urllib3 for HTTP requests #53

Merged
merged 6 commits into from
Feb 5, 2025
Merged

Use urllib3 for HTTP requests #53

merged 6 commits into from
Feb 5, 2025

Conversation

m-aciek
Copy link
Collaborator

@m-aciek m-aciek commented Feb 5, 2025

Switch from requests to urllib3.

By default, urllib3 will retry requests 3 times and follow up to 3 redirects.

https://urllib3.readthedocs.io/en/stable/user-guide.html#retrying-requests

Next (last?) iteration after #52.


📚 Documentation preview 📚: https://pydocs-translation-dashboard--53.org.readthedocs.build/

@m-aciek m-aciek changed the title Retry plausible Retry Plausible request Feb 5, 2025
@m-aciek m-aciek changed the title Retry Plausible request Use urllib3 for HTTP requests Feb 5, 2025
@m-aciek m-aciek marked this pull request as ready for review February 5, 2025 10:08
@m-aciek
Copy link
Collaborator Author

m-aciek commented Feb 5, 2025

For what it's worth I couldn't find a similar feature request in requests issue tracker, so I've added one: psf/requests#6887

Copy link
Collaborator

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/hynek/stamina is another option if we need more control later.

@m-aciek m-aciek merged commit 6bc689e into main Feb 5, 2025
3 checks passed
@m-aciek m-aciek deleted the retry-plausible branch February 5, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants