Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain "recent" part of the completion bar #73

Merged
merged 11 commits into from
Mar 11, 2025
Merged

Explain "recent" part of the completion bar #73

merged 11 commits into from
Mar 11, 2025

Conversation

m-aciek
Copy link
Collaborator

@m-aciek m-aciek commented Mar 5, 2025

Make the completion bar with the recent progress part self-explanatory. That way the visualisation should be more understandable, and the whole table more informative.

cc @encukou


📊 Dashboard preview 📊: https://python-docs-translations.github.io/dashboard/73/merge/

@m-aciek
Copy link
Collaborator Author

m-aciek commented Mar 5, 2025

I wonder now with text of different lengths in rows, doesn't it look better when aligned to left?

Zrzut ekranu 2025-03-5 o 14 48 30

@StanFromIreland
Copy link
Collaborator

doesn't it look better when aligned to left?

I disagree here, in my opinion centered is better in the case of the completion bar.

@encukou
Copy link

encukou commented Mar 6, 2025

To me, it looks great either way! Thank you for adding the info!

Format nitpick: putting the number in parentheses with a + and without recently, like (+53.80%), seems shorter but still understandable (with a note “the number in parentheses in shows change in the last 30 days”).

(FWIW, Python can add both + and %: "({:+.2%})".format(project.completion/100))

@m-aciek m-aciek marked this pull request as ready for review March 6, 2025 22:46
@StanFromIreland StanFromIreland requested a review from encukou March 6, 2025 22:51
@encukou
Copy link

encukou commented Mar 7, 2025

This looks great to me, thanks!

@StanFromIreland
Copy link
Collaborator

Maybe a minor padding?
image

@m-aciek
Copy link
Collaborator Author

m-aciek commented Mar 9, 2025

Maybe a minor padding?
image

In practice it would be to display the appended text instead of inside the bar at lower width.

@m-aciek
Copy link
Collaborator Author

m-aciek commented Mar 11, 2025

Maybe a minor padding?

It's not trivial to implement, as adding a padding CSS property to the bar breaks rendering of near-zero completion (it's too big). We would need to complicate the DOM model of the bar to get the width of the bare text, as we check now only for the bar width and width with the overflow, only when it happens. Let's merge it as is now.

@m-aciek m-aciek merged commit 456a081 into main Mar 11, 2025
4 checks passed
@m-aciek m-aciek deleted the explain-recent branch March 11, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants