Skip to content

Add sample workflows #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

StanFromIreland
Copy link
Contributor

I need to work on a good transifex download workflow. Adding file for now.

What do you think about these workflows? I will write some docs for them once we settle on what the workflows are.

Copy link
Collaborator

@rffontenelle rffontenelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I'd love to provide actions that could be used by the language teams

But, yeah, we can work we samples that help the job.

One problem with calling lint and build on cron is that they might run even when there is no commit, which might be unnecessary. Also, committing translations in the pull workflow won't trigger the 'push' event in the other workflows. Maybe we can integrate them in a way that pulling & committing translations triggers lint and build ? I did this in sphinx-doc-translations using workflow_dispatch in the target workflow.

@StanFromIreland
Copy link
Contributor Author

TBH I'd love to provide actions that could be used by the language teams
But, yeah, we can work we samples that help the job.

This was my reasoning, but we cannot cover everything so a basic sample with a doc on how to customize I think is the way to go. (Also I know they are not all strictly transifex but they are useful for all translation projects nonetheless and it will be easier to link to)

One problem with calling lint and build on cron is that they might run even when there is no commit, which might be
unnecessary.

Sometimes useful to catch issues at least in PL (e.g. Sphinx pin)

Also, committing translations in the pull workflow won't trigger the 'push' event in the other workflows.

Will it not? Interesting, I though it would.

Maybe we can integrate them in a way that pulling & committing translations triggers lint and build ?

This can be done if the files are merged (needs: ...) but I have separated them to make it more accessible. I don't know what to do with this one.

@StanFromIreland
Copy link
Contributor Author

I did this in sphinx-doc-translations using workflow_dispatch in the target workflow.

I feel there has to be an easier way. I will look into it, you would think gh would have though of this.

@StanFromIreland
Copy link
Contributor Author

There are two options, add a token to actions/checkout, or this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants