Skip to content

Deprecate __version__ attribute #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

Secrus
Copy link
Collaborator

@Secrus Secrus commented Apr 22, 2025

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@Secrus Secrus changed the title Deprecate __version__ attribute Deprecate __version__ attribute Apr 22, 2025
@Secrus Secrus force-pushed the deprecate-version branch from 14cc5f0 to c948248 Compare April 22, 2025 10:47
Copy link

codspeed-hq bot commented Apr 22, 2025

CodSpeed Performance Report

Merging #897 will not alter performance

Comparing Secrus:deprecate-version (a151d1a) with master (e57ca8e)

Summary

✅ 1 untouched benchmarks

Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of like having __version__ attrs in there, as importlib.metadata is surprisingly slow, but I guess not much should really be looking at version anyway

@Secrus
Copy link
Collaborator Author

Secrus commented Apr 23, 2025

I kind of like having __version__ attrs in there, as importlib.metadata is surprisingly slow, but I guess not much should really be looking at version anyway

Looking at version shouldn't be something one does too often, and I prefer we have a single (or rather reduce from 3 to 2) source of version.

@Secrus Secrus force-pushed the deprecate-version branch from c948248 to a151d1a Compare April 23, 2025 10:14
@Secrus Secrus merged commit fa1a4f2 into python-pendulum:master Apr 23, 2025
18 checks passed
@Secrus Secrus deleted the deprecate-version branch April 23, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants