-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add type hints #8362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Add type hints #8362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yay295
reviewed
Sep 9, 2024
This is such a big PR I've not found time to review it yet, so let's either ask for reviewers from the community (for example, via #8029), or just go ahead and merge it if you'd like it in the next release. |
This was referenced Dec 23, 2024
Merged
Merged
1f47e4b
to
5ad234c
Compare
bbbbf8f
to
35f3299
Compare
Merged
3ddbb6b
to
52acc1c
Compare
316d80a
to
5406def
Compare
This was referenced Apr 10, 2025
Merged
2fd1111
to
1c214e1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8029
In order to add type hints to the following
Image
methodsI've made a few changes.
Image
now hasI added an
__enter__()
and__exit__()
toImageFile
, so thatwith Image.open(...):
will type hint anImageFile
instance. I also moved_close_fp()
to ImageFile, as it is only used when exiting anImageFile
instance.I also moved
get_child_images()
fromImage
toImageFile
. It requires the use ofself.fp
, so this made sense to me, but feel to tell me it should stay inImage
.Believe it or not, all the other changes in this PR flowed out from there.