Use enums for Modes and RawModes in C #9100

eyedav · 2025-07-19T15:46:21Z

Rebase of PR #8510 (Use enums for Modes and RawModes in C) on latest main, done during EuroPython25's Sprint: creating a new PR as agreed with @wiredfool.

src/libImaging/Filter.c

src/libImaging/Pack.c

src/libImaging/Resample.c

src/libImaging/Unpack.c

src/libImaging/Pack.c

src/libImaging/Unpack.c

setup.py

src/libImaging/Chops.c

Co-authored-by: Hugo van Kemenade <[email protected]>

radarhere · 2025-10-11T05:17:18Z

src/libImaging/Mode.h

+typedef enum {
+    IMAGING_RAWMODE_UNKNOWN,
+
+    // Non-rawmode aliases.


I don't understand this comment. RawModeID isn't filled with items related to rawmodes?

I think that's that these are the same as modes, so that IMAGING_MODE_1 == IMAGING_RAWMODE_1

hugovk · 2025-10-15T07:57:45Z

@radarhere Would you like to push eyedav#3 directly here?

radarhere · 2025-10-15T08:03:29Z

I tried, but for some reason I'm not sure of, I don't seem to have permission.

hugovk · 2025-10-15T08:09:22Z

It does say "Maintainers are allowed to edit this pull request" but 🤷

New PR?

Yay295 and others added 30 commits July 19, 2025 14:29

use a struct for mode names instead of just a string

cd93629

add special modes

63a45ad

use mode structs in _imaging.c

12409e4

use mode structs in tkImaging.c

a37f53c

use mode structs in encode.c and decode.c

a12dc30

use mode structs in Access.c

0df2ed0

use mode structs in AlphaComposite.c

82182ba

use mode structs in Bands.c

d0541a7

use mode structs in Blend.c

38c75b9

use mode structs in BoxBlur.c

6f6e1f9

use mode structs in Chops.c

ecf1fce

use mode structs in Convert.c

9bf3495

use mode structs in Draw.c

bcfe5f2

use mode structs in Effects.c

b5c4b82

use mode structs in File.c

19c0d1d

use mode structs in Fill.c

6202eef

use mode structs in Filter.c

af22363

use mode structs in Geometry.c

cfe9155

use mode structs in GetBBox.c

2668338

use mode structs in Histo.c

2749770

use mode structs in Jpeg2KDecode.c

3327258

use mode structs in Jpeg2KEncode.c

98a2c63

use mode structs in JpegDecode.c

30d4cd0

use mode structs in JpegEncode.c

0abfdd2

use mode structs in Matrix.c

378c3bd

add function isModeI16() to check if a mode is an I;16 mode

4906285

use mode structs in Pack.c

e5bc5b4

use mode structs in Palette.c

af3c24e

use mode structs in Paste.c

2a9d712

use mode structs in Point.c

7e48697