-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Poetry documentation proofread #10354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poetry documentation proofread #10354
Conversation
* initialise -> initialize * licence -> license * honour, behaviour -> honor, behaviaor
Reviewer's Guide by SourceryThis pull request focuses on enhancing the Poetry documentation through proofreading and minor corrections. It includes fixes for grammar, tense agreement, and the standardization of language to American English. Additionally, it improves sentence structure and ensures consistency in technical terms. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @deronnax - I've reviewed your changes - here's some feedback:
Overall Comments:
- Thanks for improving the documentation, paying attention to grammar and clarity is really important.
- It's great that you've broken down the changes into smaller commits by topic, making it easier to review.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Most changes look good to me. Just one thing:
I think this is wrong because you speak it like "es-dist" (starting with a vowel) and if I remember correctly, the decision between "a" and "an" depends on the pronouncation - not how it is written. |
I checked and you are right (e.g Britannica Dictionary: How do you know whether to use "a" or "an"? |
This reverts commit c29bf16.
5cb3fef
to
1975818
Compare
Deploy preview for website ready! ✅ Preview Built with commit 15c2476. |
Pull Request Check List
No issue number. Documentation-only changes.
Most of them were suggested to me by the Grazzie spelling and grammar plugin from PyCharm. However, I reviewed them all, and only selected the most relevant. All the changes are broken down in several commits by topics, which makes it so you can accept only some of them if you want to (thouh I would advise to take them all).
Some changes:
fix usage of "an sdist"Slightly more controversial: add commas where missing. Despite maybe looking sentencious, it helps giving the sentences a clearer structure, breaking them in smaller parts. I think it is particularly usefull to people whose English is not the main language.
Summary by Sourcery
Proofread and improve documentation for Poetry, focusing on grammar, spelling, and clarity across multiple documentation files.
Documentation:
Chores: