fix(models): remove app_name from abstract models #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a subclass doesn't overrider Meta, it inherits the app_name from the abstract class what is not descired behavior as it lands migrations into social_django instead of the actuall app. Fixes python-social-auth#496
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #675 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 39 40 +1
Lines 1172 1185 +13
Branches 144 66 -78
=======================================
+ Hits 1075 1087 +12
- Misses 72 73 +1
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a subclass doesn't overrider Meta, it inherits the app_name from the abstract class what is not descired behavior as it lands migrations into social_django instead of the actuall app.
Fixes #496