Skip to content

Add support to SOCIAL_AUTH_OIDC_PROMPT and others #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 26, 2025
Merged

Add support to SOCIAL_AUTH_OIDC_PROMPT and others #1127

merged 8 commits into from
May 26, 2025

Conversation

rgaiacs
Copy link
Contributor

@rgaiacs rgaiacs commented Apr 24, 2025

This is related to #1124.

This is my first PR to this project. Feedback is welcome, specially regarding

  • how to trigger a logging warning?
  • how to add a test to this new feature?

If this PR looks good, I will submit others to complete #1124.

rgaiacs added a commit to rgaiacs/social-docs that referenced this pull request Apr 24, 2025
@rgaiacs
Add documentation of optional parameter in OpenID Connect
6605cf9 
Related to python-social-auth/social-core#1124

Supplement python-social-auth/social-core#1127
@rgaiacs rgaiacs mentioned this pull request Apr 24, 2025
Merged
@rgaiacs
Copy link
Contributor Author

rgaiacs commented Apr 24, 2025

A PR with documentation was sent, see python-social-auth/social-docs#288.

@codecov Codecov
Copy link

codecov bot commented Apr 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 42.55319% with 27 lines in your changes missing coverage. Please review.

Project coverage is 77.75%. Comparing base (4e5ad63) to head (7e4e838).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
social_core/backends/open_id_connect.py 39.02% 18 Missing and 7 partials ⚠️
social_core/exceptions.py 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1127      +/-   ##
==========================================
- Coverage   77.87%   77.75%   -0.12%     
==========================================
  Files         353      353              
  Lines       10794    10854      +60     
  Branches      471      485      +14     
==========================================
+ Hits         8406     8440      +34     
- Misses       2222     2241      +19     
- Partials      166      173       +7
Flag Coverage Δ
unittests 77.75% <42.55%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

nijel
nijel reviewed Apr 24, 2025
View reviewed changes
Copy link
Member

@nijel nijel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If warnings were meant to indicate errors in the configuration, I think it's better to fail directly. Nobody will notice warnings.

As for the tests, it could check whether the configured parameters are included in the request to the authentication server.

@rgaiacs rgaiacs force-pushed the 1124-add-openid-connect-optional-parameter branch from ea244d6 to 36e841d Compare April 25, 2025 12:54
@rgaiacs rgaiacs changed the title Add support to SOCIAL_AUTH_OIDC_PROMPT Add support to SOCIAL_AUTH_OIDC_PROMPT and others Apr 25, 2025
@rgaiacs
Copy link
Contributor Author

rgaiacs commented Apr 25, 2025

Thanks for the feedback. I expanded to match the list of parameters explicitly mentioned in the Authentication Request section.

I don't implemented all parameters because of my limited knowledge of OpenID.

nijel
nijel reviewed Apr 25, 2025
View reviewed changes
rgaiacs added a commit to rgaiacs/social-docs that referenced this pull request May 2, 2025
@rgaiacs
Add documentation of optional parameter in OpenID Connect
32aa5a5 
Related to python-social-auth/social-core#1124

Supplement python-social-auth/social-core#1127
@rgaiacs
Copy link
Contributor Author

rgaiacs commented May 2, 2025

New exceptions were defined.

nijel
nijel requested changes May 5, 2025
View reviewed changes
social_core/backends/open_id_connect.py Outdated
display = self.setting("DISPLAY", default=self.DISPLAY)
if display is not None:
if not display:
raise AuthMissingParameter("OpenID Connect display value cannot be empty string.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK these should take self as a first parameter.

nijel
nijel reviewed May 26, 2025
View reviewed changes
nijel added a commit to python-social-auth/social-docs that referenced this pull request May 26, 2025
@rgaiacs @nijel
feat: Add documentation of optional parameter in OpenID Connect (#288)
fcd0e25 
* Add documentation of optional parameter in OpenID Connect

Related to python-social-auth/social-core#1124

Supplement python-social-auth/social-core#1127

* fix permissions

---------

Co-authored-by: Michal Čihař <[email protected]>
@nijel nijel merged commit 8f2669c into python-social-auth:master May 26, 2025
10 of 12 checks passed
@nijel
Copy link
Member

nijel commented May 26, 2025

Merged, thanks for your contribution!

@nijel nijel mentioned this pull request May 26, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nijel nijel nijel requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgaiacs @nijel