GH-92737: Corrected posixpath behaviour to not assume '//' is equivalent to '/'. #103798
+22
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quivalent to '/'.
|
@barneygale would you be able to review this when you get a chance? I wasn't sure how disruptive this would be for users who were relying on the previous implementation, so I haven't added in any warnings/deprecation, but happy to do so if desired. |
barneygale
requested changes
Apr 29, 2023
Co-authored-by: Barney Gale <[email protected]>
Co-authored-by: Barney Gale <[email protected]>
|
I didn't expect the Spanish Inquisition |
|
@barneygale would you be able to take a look at this when you get a chance? |
|
Hi, friendly ping @barneygale, would you mind taking another look at this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-92737 - added roots equivalent check to
posixpath.relpathsimilar tontpath.relpath.posixpath.relpath