gh-128842: collect JIT memory stats via pystats #128941
Open
+104
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegorusso
requested review from
brandtbucher and
savannahostrowski
as code owners
|
I deleted the branch by error. It's now restored. |
Collect via pystats the following metrics: * total memory size * code size * trampoline size * data size * padding seze * freed memory size
diegorusso
added
topic-JIT
type-feature
|
This is what the output looks like: https://gist.github.com/diegorusso/51df19523da041035ec819dac18ae958 |
brandtbucher
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Thanks for tackling this! The JIT changes look good to me. Really like the histogram, that's super useful information.
@mdboom, looping you in to review the stats changes.
Two very minor requests, if they're easy to do (fine if it's not worth the effort):
- Can capitalize "jit" in the output stats? It looks kind of weird when lowercased like that.
- Can we automatically detect and drop histogram buckets at the low end of the range with 0 values, and start the histogram with the first nonzero value?
mdboom
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect via pystats the following metrics:
Also print and histogram of the traces total size.