gh-128889: Zero out memory ctypes for generated struct layout tests #128944
+147
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC 15 doesn't set padding bits to zero (as it's allowed, according to standard). Let's zero the test structs explicitly.
Even with this PR, the tests still depend on the compiler keeping padding bits unchanged when surrounding values are set. (AFAIK, this is not guaranteed by the standard, and when bitfields are involved, changing padding bits might make sense as an optimization.)
Removing that limitation will be easier with introspection attributes I want to add in gh-128715.