Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-128982: Substitute regular expression in http.cookiejar.join_header_words for an efficient alternative #128983

Merged
merged 4 commits into from
Feb 26, 2025
Merged

gh-128982: Substitute regular expression in http.cookiejar.join_header_words for an efficient alternative #128983

merged 4 commits into from
Feb 26, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Jan 18, 2025 •
edited by bedevere-app bot
Loading

@picnixz
Improve the performance http.cookiejar.join_header_words.
72b6c36 
The function does not anymore rely on a regular expression
to find alphanumeric characters and underscores.
@picnixz
blurb
0bbced2
@bedevere-app bedevere-app bot mentioned this pull request Jan 18, 2025
Closed
@picnixz picnixz requested a review from vadmium February 12, 2025 11:21
@picnixz picnixz mentioned this pull request Feb 16, 2025
Open
@encukou encukou merged commit 56e1900 into python:main Feb 26, 2025
39 checks passed
encukou added a commit to encukou/cpython that referenced this pull request Feb 26, 2025
@encukou
Revert "pythongh-128982: Substitute regular expression in `http.cooki…
9d37429 
…ejar.join_header_words` for an efficient alternative (pythonGH-128983)"

This reverts commit 56e1900.
@encukou encukou mentioned this pull request Feb 26, 2025
Merged
encukou added a commit that referenced this pull request Feb 26, 2025
@encukou
gh-128982: Revert "#128982: Substitute regular expression in http.coo…
9e474a9 
…kiejar.join_header_words for an efficient alternative (GH-128983)" and add tests (GH-130584)

* Revert "gh-128982: Substitute regular expression in `http.cookiejar.join_header_words` for an efficient alternative (GH-128983)"

This reverts commit 56e1900.

* Add tests
@picnixz picnixz deleted the perf/match/cookiejar-128982 branch March 1, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@tomasr8 tomasr8 tomasr8 approved these changes

@vadmium vadmium Awaiting requested review from vadmium

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@picnixz @serhiy-storchaka @tomasr8 @encukou