gh-129965: Add missing MIME types #129969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compare https://www.webmproject.org/docs/container/#naming and .webm addition
encukou
reviewed
Feb 20, 2025
| '.opus' : 'audio/opus', | ||
| '.aif' : 'audio/x-aiff', | ||
| '.aifc' : 'audio/x-aiff', | ||
| '.aiff' : 'audio/x-aiff', | ||
| '.ra' : 'audio/x-pn-realaudio', | ||
| '.wav' : 'audio/x-wav', |
There was a problem hiding this comment.
This will make mimetypes.MimeTypes().guess_extension('audio/x-wav') no longer work. Is that expected?
There was a problem hiding this comment.
Yes, we can only have a single type per extension with this dict implementation (there's also #122632 that proposes dealing with duplicates; I've not looked closely at it).
If we can only choose one, I think handling for the standards-based type is more useful than an x- extension.
Also mimetypes.MimeTypes().guess_type('filename.wav') now gives the preferred result.
This is also a reason why this kind of change is only made as a feature with no backports. But happy to revert this one if you prefer.
Misc/NEWS.d/next/Library/2025-02-10-19-16-48.gh-issue-129965.B6wik0.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Petr Viktorin <[email protected]>
encukou
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--129969.org.readthedocs.build/