-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
gh-83461: Don't allow datetime parsing to accept non-ASCII digits #131008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
StanFromIreland
wants to merge
20
commits into
python:main
Choose a base branch
from
StanFromIreland:ascii-strptime
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+56
−16
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
c20c6da
Initial
StanFromIreland decd90f
Fix NEWS
StanFromIreland 81276eb
sggestion
StanFromIreland 0a3e67b
Alphabetical order…
StanFromIreland 5d1d53d
Benedikts suggestions
StanFromIreland a0b0f07
Add docs and tests for time.strptime
StanFromIreland d0e6a1f
Cover the majority
StanFromIreland 2f6d8e2
Cover all
StanFromIreland ccabadf
Clean up
StanFromIreland 35bc090
Benedikt's Doc suggestions
StanFromIreland 0637c29
Apply suggestions from code review
StanFromIreland 71d7c8a
Re-word news
StanFromIreland 212c763
Apply suggestions from code review
StanFromIreland 0201347
PEP 8
StanFromIreland bebb241
REQUESTED CHANGES
StanFromIreland 40d2368
Refactor documentation changes
pganssle 77c936a
Clarify non-ASCII parsing in news
pganssle e652581
fixup! Refactor documentation changes
pganssle 0115ee4
Unrequire ascii
StanFromIreland 25a6705
Merge branch 'main' into ascii-strptime
StanFromIreland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/Library/2025-03-09-11-01-00.gh-issue-83461.auwd13.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Digits passed to :meth:`datetime.date.strptime`, :meth:`datetime.datetime.strptime`, | ||
:meth:`datetime.time.strptime` and :meth:`time.strptime` must now be ASCII in | ||
non-locale-specific numeric format codes. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention the "non-locale-specific numeric format codes" here or, since it's not officially supported, we can be a bit lazy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pganssle Do you want to do this too? Or should I?