Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-121970: Extract pydoc_topics into a new extension #131256

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Mar 14, 2025

It seems the error was in #130492, the attempted fix. That PR stripped all trailing whitespace, which inadvertantley also removed the final newline, leading to syntax errors, as there were four consecutive quotation marks.

This PR reapplies the reverted commit (#131245), adds a trailing newline, and finally regenerates pydoc_data/topics.py.

A


📚 Documentation preview 📚: https://cpython-previews--131256.org.readthedocs.build/

@AA-Turner AA-Turner requested a review from hugovk as a code owner March 14, 2025 18:20
@AA-Turner AA-Turner added the docs Documentation in the Doc dir label Mar 14, 2025
@hugovk
Copy link
Member

hugovk commented Mar 14, 2025

Thanks! Do you have a good way to reproduce the original failure in a minimal way?

@AA-Turner
Copy link
Member Author

Thanks! Do you have a good way to reproduce the original failure in a minimal way?

$ git switch -C investigate db62557e3d1b0de4ca17786bd53f9c825ad88721
$ make -CDoc pydoc-topics
$ cp Doc/build/pydoc-topics/topics.py Lib/pydoc_data/topics.py
$ git commit -am "regenerate pydoc-topics"
$ make ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge docs Documentation in the Doc dir skip news
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants