Skip to content

gh-115783: Deprecate support for invalid ISO formats in datetime.fromisoformat #131522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented Mar 20, 2025

This deprecates the support for invalid formats in datetime.fromisoformat to be removed in 3.15.

@StanFromIreland StanFromIreland marked this pull request as ready for review March 20, 2025 18:09
Copy link
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Before we go too far with this I would like to start a thread on discourse to try and gauge how disruptive this is likely to be, and whether other folks agree that we should deprecate instead of just fixing the function.

It is the safe and cautious thing to do to issue a warning, but also we aren't technically deprecating anything since we didn't intend for this function to be able to parse things other than the output of isoformat or valid ISO 8601 date/time strings.

@bedevere-app
Copy link

bedevere-app bot commented Mar 20, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@StanFromIreland
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Mar 20, 2025

Thanks for making the requested changes!

@pganssle: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from pganssle March 20, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants