gh-130870: Preserve GenericAlias
subclasses in typing.get_type_hints()
#131583
+34
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to #130897, that avoids recreating
GenericAlias
instances two times (no noticeable performance improvement but cleans up the implementation).It also fixes the
GenericAlias
reconstruction in_strip_annotations()
, and as such I moved the logic into a separate function.This approach has the benefit of not losing the
__unpacked__
property of theGenericAlias
if no forward annotation is present in the type hint. That is:A couple tests are failing due to this, I'm not sure how we can test this? Maybe like:
typing._eval_type
is not preservingGenericAlias
subclasses #130870