Skip to content

gh-46236: Add Py_UNICODE_REPLACEMENT_CHARACTER doc #132706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented Apr 18, 2025

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Apr 18, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Apr 18, 2025
@bedevere-app bedevere-app bot mentioned this pull request Apr 18, 2025
33 tasks
@brianschubert
Copy link
Contributor

brianschubert commented Apr 18, 2025

I notice that Py_UNICODE_REPLACEMENT_CHARACTER is under the "Internal API" section in Include/unicodeobject.h. Does that say anything about whether this should be documented?

@@ -193,6 +193,14 @@ are available through these macros which are mapped to C functions depending on
the Python configuration.


.. c:macro:: Py_UNICODE_REPLACEMENT_CHARACTER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this fits in the character properties section. Maybe it would make sense to add a new "Constants" section for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants