gh-132734: Add new constants for Bluetooth sockets #132735
Open
+271
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doc/library/socket.rst
Outdated
| Options names for use with :const:`BTPROTO_HCI`. | ||
| Availability and format of the option value depend on platform. | ||
|
|
||
| .. availability:: Linux and BSD |
There was a problem hiding this comment.
Suggested change
| .. availability:: Linux and BSD | |
| .. availability:: Linux, FreeBSD |
Consistent with your first one, also we cannot officially guarantee *BSD support
There was a problem hiding this comment.
It is not only FreeBSD. In several places I use BSD as a shortcut for FreeBSD, NetBSD and DragonFly BSD.
Note that different constants are available on different platforms.
Comment on lines
+729
to
+730
| on NetBSD and DragonFly BSD. | ||
| Added :const:`!HCI_DATA_DIR` on FreeBSD, NetBSD and DragonFly BSD. |
There was a problem hiding this comment.
Suggested change
| on NetBSD and DragonFly BSD. | |
| Added :const:`!HCI_DATA_DIR` on FreeBSD, NetBSD and DragonFly BSD. | |
| for NetBSD and DragonFly BSD. | |
| Added :const:`!HCI_DATA_DIR` for FreeBSD, NetBSD and DragonFly BSD. |
I think for is more fitting here
There was a problem hiding this comment.
Is it so? I thought that it is more common to write "on platform" than "for platform". There are many examples of the former, and not many of the latter.
serhiy-storchaka
added
docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--132735.org.readthedocs.build/