Update the PCbuild sub-projects list #133397
Open
+18
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
commented
May 4, 2025
Comment on lines
+217
to
+218
|
|
||
| liblzma |
There was a problem hiding this comment.
I think changing these from _lzma, _ssl, and _sqlite3 to liblzma, openssl, and sqlite3 is correct, as the former projects are the Python modules and the latter are the wrappers for external libraries, which is what this section describes.
There was a problem hiding this comment.
They're still described as "Python wrapper for ...", so should still be the names of the vcxproj file in PCbuild?
There was a problem hiding this comment.
Would it make sense to list both? Eg "openssl, _ssl"
There was a problem hiding this comment.
It's worth pointing out the additional builds, and makes sense to bundle them together. So yeah, but put the wrapper first and then mention the library project in the text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.