gh-133361: move the explanation of dict equal before its use #133424
+25
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requesting @terryjreedy , is this what you wanted? |
|
Yes, thanks! |
terryjreedy
reviewed
May 6, 2025
|
Not quite. I meant to move 5011-3, "Dictionaries compare equal ... TypeError." to the beginning of 4826, "To illustrate,", with the latter part of the same paragraph. I think the latter should be expanded to "To illustrate dict creation and equality,". I think moving the order text and example, as you did, is also good. I will look at the preview after the additional change. |
|
@terryjreedy Hi! I have seen your suggestions. Could you please review again? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the explanation of dict's
==operator before its use.📚 Documentation preview 📚: https://cpython-previews--133424.org.readthedocs.build/