[3.13] gh-133441: Fix STORE_ATTR_WITH_HINT bytecode #133446
Open
+23
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deoptimize if the dict is a dict subclass.
|
It looks like the offending code is on main as well. |
I failed to write code to trigger the bug on main, so I'm not sure that main is affected. |
| @@ -1594,6 +1594,24 @@ def make_pairs(): | |||
| self.assertEqual(d.get(key3_3), 44) | |||
| self.assertGreaterEqual(eq_count, 1) | |||
|
|
|||
| def test_store_attr_with_hint(self): | |||
| # gh-133441: Regression test for STORE_ATTR_WITH_HINT bytecode | |||
There was a problem hiding this comment.
This should be in test_opcache not test_dict IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deoptimize if the dict is a dict subclass.
_PyEval_EvalFrameDefault#133441