Skip to content

gh-132775: Revert "gh-132775: Add _PyCode_VerifyStateless() (gh-133221)" #133497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

encukou
Copy link
Member

@encukou encukou commented May 6, 2025

This reverts commit d270bb5.

Note that the test functions in _code_definitions are not reverted.

…)"

This reverts commit d270bb5.

Note that the test functions in _code_definitions are not reverted.
@encukou encukou requested a review from markshannon as a code owner May 6, 2025 07:19
@encukou encukou changed the title Revert "gh-132775: Add _PyCode_VerifyStateless() (gh-133221)" gh-132775: Revert "gh-132775: Add _PyCode_VerifyStateless() (gh-133221)" May 6, 2025
@encukou
Copy link
Member Author

encukou commented May 6, 2025

@hugovk I need to step away for a doctor's appointment. Here's what I have, I haven't checked this very well.

@hugovk
Copy link
Member

hugovk commented May 6, 2025

@encukou Thank you!

@hugovk
Copy link
Member

hugovk commented May 6, 2025

!buildbot ios

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @hugovk for commit e7d7e26 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133497%2Fmerge

The command will test the builders whose names match following regular expression: ios

The builders matched are:

  • iOS ARM64 Simulator PR

@hugovk
Copy link
Member

hugovk commented May 6, 2025

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @hugovk for commit e7d7e26 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133497%2Fmerge

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

@ambv
Copy link
Contributor

ambv commented May 6, 2025

iOS buildbot green! No Android results yet.

@ambv
Copy link
Contributor

ambv commented May 6, 2025

It's weird since the Android builders aren't building anything else at the moment. Looking at buildmaster.

@ambv
Copy link
Contributor

ambv commented May 6, 2025

Master claims it added jobs:

2025-05-06 07:36:07+0000 [HTTP11ClientProtocol (BufferingTLSTransport),client] Received 1 changes from GitHub PR #133497
2025-05-06 07:36:07+0000 [-] added change with revision e7d7e26eee5fa9dcd6b23d1dd00f96cd083aff8b to database
2025-05-06 07:36:07+0000 [-] injected change 41998

Weird. Let's try again.

@ambv
Copy link
Contributor

ambv commented May 6, 2025

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ambv for commit e7d7e26 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133497%2Fmerge

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

@ambv
Copy link
Contributor

ambv commented May 6, 2025

Now it worked, builds started.

@hugovk
Copy link
Member

hugovk commented May 6, 2025

And Android green.

@hugovk hugovk merged commit 3c73cf5 into python:main May 6, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants